fix names of fields in schema generation #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to wrap these all in newtypes to catch exactly this kind of issue (we saw something similar before) but I struggled because a lot of this stuff is in the I still think we should do this, but it requires a bit of thought. |
SamirTalwar
approved these changes
Mar 15, 2024
| collections.extend(native_queries); | ||
|
|
||
| let table_types = | ||
| BTreeMap::from_iter(metadata.tables.0.iter().map(|(collection_name, table)| { |
There was a problem hiding this comment.
FWIW, BTreeMap::from_iter might be more idiomatically expressed as .collect().
|
@SamirTalwar Perhaps we should rename the field |
|
@SamirTalwar ah, that's a breaking change, and I don't care to make one right now :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
/schemaendpoint was exposing the wrong column names in object types. This PR fixes this.How
columns, referenced by tables, native queries, etc. Have a type that looks somewhat like this:
BTreeMap<String, ColumnInfo>.ColumnInfolooks somewhat like this:ColumnInfo { name: String, ... }.The
Stringin the map refers to the external name that ndc-spec queries should reference, while theColumnInfoname refers to the database column name.By mistake, were reporting the
ColumnInfoname in the schema, instead of the String from the map.We fix this by referring to the right name, and use
iter()on the BTreeMap instead ofvalues().