Cast-extend aggregation functions #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plcplc
force-pushed
the
plc/cast-extend-aggregate-functions
branch
from
196aa62 to
cd37a07
Compare
plcplc
force-pushed
the
plc/cast-extend-aggregate-functions
branch
from
cd37a07 to
99c364d
Compare
| ORDER BY | ||
| -- Prefer uncast argument. | ||
| NOT argument_casted DESC, | ||
| -- Arbitrary desperation: Lexical ordering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR makes the introspection of aggregation functions take implicit casts into account.
This enables aggregation functions on domain types, which would typically only be defined on the base type.
It also enables certain other aggregations for scalar types that weren't defined before, most notably aggregation functions for
float4on CockroachDB, which becomes accessible through implicit casts tofloat8.How
The cast-extension for aggregation functions introspection code is based on the same for comparison operators.
We also change our notion of "occurring scalar types" to include the return types aggregation functions. Previously, aggregation functions could be filtered out if their return type didn't feature in the set of occurring scalar types, which was unnecessarily strict.