Support type representations in general #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupi
approved these changes
Apr 1, 2024
| }) | ||
| } | ||
|
|
||
| fn base_type_representations() -> database::TypeRepresentations { |
There was a problem hiding this comment.
Let's add a comment saying what this is please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for type representations for base types and domain types, building on top of the existing support for type representation hinting of enum types.
Note that the wide numeric types default to numeric representation, see the comment in the code. This will be relayed in the user docs in a follow-up PR.
How
The introspection query is seeded with a list of type representations for base types, which it will use to build the final list of represenations for base types, domain types, and enum types.