Support nested fields of object type #404
Conversation
| /// | ||
| /// - `row_to_json` takes a row and converts it to a json object. | ||
| /// - `coalesce(<thing>, <otherwise>)` returns `<thing>` if it is not null, and `<otherwise>` if it is null. |
There was a problem hiding this comment.
This part is probably copy paste from the with_default version right? :)
There was a problem hiding this comment.
Right - I've pruned it more now. Thanks
|
|
||
| /// Translate rows part of query to sql ast. | ||
| pub fn translate_rows_query( | ||
| struct JoinNestedFieldInfo { |
| alias: sql::ast::TableAlias, | ||
| } | ||
|
|
||
| fn transalate_nested_field_joins(joins: Vec<JoinNestedFieldInfo>) -> Vec<sql::ast::Join> { |
| join_nested_fields: &mut Vec<JoinNestedFieldInfo>, | ||
| join_relationship_fields: &mut Vec<relationships::JoinFieldInfo>, | ||
| ) -> Result<sql::ast::ColumnReference, Error> { | ||
| match field { |
There was a problem hiding this comment.
I would really appreciate some comments in-between some code chunks summarizing what they do. Rust can be quite verbose and it gives some direction to reading the code (and also easier to verify the intent matches the code).
There was a problem hiding this comment.
Agree! I've added some commentary explaining how translate_nested_field goes about its business.
| state: &mut State, | ||
| // The table reference the column lives on | ||
| current_table: &TableNameAndReference, | ||
| // The column to extract nested fields from |
There was a problem hiding this comment.
Can these be ///? Does that work?
There was a problem hiding this comment.
It seems rust does not support /// (or #[doc()] attributes) on function arguments. I've moved these to the main /// block under an # Aruguments heading.
I'm fine either way myself.
|
@soupi: Thanks for the review. I've tried to improve the documentation :-) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 participants
What
This PR adds support for selecting nested fields that arise from composite objects.
The case for nested fields which are arrays will be treated in a followup PR.
How
The SQL generated is of the form