-
Notifications
You must be signed in to change notification settings - Fork 5
Support nested fields of array type #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this was staged by accident. I have removed it.
crates/query-engine/translation/src/translation/query/fields.rs
Outdated
Show resolved
Hide resolved
crates/query-engine/translation/src/translation/query/fields.rs
Outdated
Show resolved
Hide resolved
crates/query-engine/translation/src/translation/query/fields.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com>
Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com>
Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for going into such detail with the comments and the examples.
|
indeed, this is very nice! |
What
This PR adds support for selecting nested fields that arise from composite arrays.
How
This builds on the earlier work for nested field selection support for objects.
The main change is that the lateral joins that project the nested field have to be nested rather than adjacent as well, since there are multiple rows in the case of arrays.
The generated SQL is now of the form: