Skip to content

Conversation

@SamirTalwar
Copy link
Contributor

What

We don't want users to have to install the Visual C++ Redistributable to use the ndc-postgres CLI plugin.

How

We can instruct rustc to link statically with the C runtime with the -C target-feature=+crt-static flag. See RFC 1721 for details.

@SamirTalwar SamirTalwar requested a review from a team April 10, 2024 08:46
Copy link
Contributor

@soupi soupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@SamirTalwar SamirTalwar added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit faba39d Apr 10, 2024
@SamirTalwar SamirTalwar deleted the samirtalwar/cli-static-windows branch April 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants