Skip to content

fix: Uninstall CLI no longer reinstalls the global command#1126

Merged
hatayama merged 2 commits into
v3-betafrom
feature/hatayama/fix-global-cli-uninstall
May 14, 2026
Merged

fix: Uninstall CLI no longer reinstalls the global command#1126
hatayama merged 2 commits into
v3-betafrom
feature/hatayama/fix-global-cli-uninstall

Conversation

@hatayama
Copy link
Copy Markdown
Owner

Summary

  • Uninstall CLI now keeps the package-owned global uloop command removed instead of reinstalling it during editor startup.
  • CLI installation remains an explicit Settings action.

User Impact

  • Before this change, pressing Uninstall CLI could appear to succeed, then the editor startup flow could restore the global command.
  • After this change, users who uninstall the package-owned CLI do not have it silently reinstalled by the Unity package.

Changes

  • Removed the editor startup path that automatically ensured the global CLI was current.
  • Removed the unused ensure-current application workflow and its startup-focused tests.
  • Added a startup guard test so the infrastructure startup path does not schedule global CLI auto-install again.

Verification

  • go run ./cmd/uloop run-tests --project-path /Users/a12115/ghq/hatayama/unity-cli-loop2 --test-mode EditMode --filter-type regex --filter-value "InfrastructureEditorStartup_WhenLoaded_DoesNotScheduleGlobalCliAutoInstall|CliSetupApplicationServiceTests"
  • go run ./cmd/uloop compile --project-path /Users/a12115/ghq/hatayama/unity-cli-loop2
  • git diff --check

Closes #1123

Stop the editor startup path from reinstalling the package-owned global CLI after a user chooses Uninstall CLI. Keep CLI installation as an explicit Settings action and remove the now-unused ensure-current workflow.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@hatayama has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 36 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4575c1d3-f4e3-4dda-aaa1-562e698c3a4f

📥 Commits

Reviewing files that changed from the base of the PR and between a862688 and e34ec7d.

⛔ Files ignored due to path filters (1)
  • Packages/src/Editor/Infrastructure/CLI/GlobalCliAutoInstaller.cs.meta is excluded by none and included by none
📒 Files selected for processing (5)
  • Assets/Tests/Editor/CliSetupApplicationServiceTests.cs
  • Assets/Tests/Editor/OnionAssemblyDependencyTests.cs
  • Packages/src/Editor/Application/CliSetupApplicationService.cs
  • Packages/src/Editor/Infrastructure/CLI/GlobalCliAutoInstaller.cs
  • Packages/src/Editor/Infrastructure/InfrastructureEditorStartup.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/fix-global-cli-uninstall

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Keep the new startup guard test aligned with the repository rule that every test method states the behavior it verifies.
@hatayama hatayama merged commit 2adffbc into v3-beta May 14, 2026
7 checks passed
@hatayama hatayama deleted the feature/hatayama/fix-global-cli-uninstall branch May 14, 2026 16:24
@github-actions github-actions Bot mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant