ETT-810: update footer links, add footer tag #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carylwyatt
force-pushed
the
ETT-810-footer
branch
from
f7ccd7f to
45c8102
Compare
Ronster2018
approved these changes
Nov 7, 2025
Ronster2018
left a comment
Ronster2018
left a comment
There was a problem hiding this comment.
I've reviewed the changes and double checked the links! Everything works as expected within the scope of this ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jessica requested an update to links in the footer. I took this opportunity to address an a11y best practice by swapping out a generic div for a more-semantic
<footer>tag.This is staged on dev-3: https://dev-3.www.hathitrust.org/
There's not really a code review situation here since it's very minimal HTML swaps, but just double check those links on dev-3 are taking you to where they say they do. (Spoiler: when I first staged this, there was a typo and the link did not work. 😑 ) Always good to have a second set of eyes on it! Thanks!