More inventory work #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilhuhn
force-pushed
the
more_inventory
branch
from
d6fe374 to
8eba944
Compare
|
@jpkrohling @Jiri-Kremser Can you have a look please? |
lib/inventory/inventory_api.rb
Outdated
| # @return [Array<Resource>] List of resources, which can be empty. | ||
| def list_resources_for_feed(feed, fetch_properties = false) | ||
| fail 'Feed must be given' unless feed | ||
| the_feed = hawk_escape(feed) |
There was a problem hiding this comment.
In some places, there are parenthesis when calling hawk_escape, in other places it's without.
Also, wouldn't it be a good candidate for a monkey patching, specially if this escape is used in other non-inventory places? No need to make it system wide, though.
|
Review finished. I got a couple of questions, but it looks good to me. However, I cannot judge the inventory-specific things. |
pilhuhn
force-pushed
the
more_inventory
branch
from
11e8b3f to
6121b86
Compare
pilhuhn
force-pushed
the
more_inventory
branch
from
6121b86 to
92efee6
Compare
pilhuhn
added a commit
that referenced
this pull request
Feb 23, 2016
More inventory work especially to create entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.