Skip to content

show diffs between problem and solution #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

show diffs between problem and solution #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2958c9
soulution branch created
hax2000 Sep 28, 2020
a714e63
solution update
hax2000 Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions main/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,24 @@
from main.models import MainTable, RelatedField1, RelatedField2, RelatedField3


class MainTableRelatedFields(serializers.RelatedField):
def display_value(self, instance):
return instance

def to_representation(self, value):
return str(value)

def to_internal_value(self, data):
return self.queryset.model.objects.get(name=data)


class MainTableSerializerList(serializers.ListSerializer):

def create(self, validated_data):
records = [MainTable(**item) for item in validated_data]
return self.child.Meta.model.objects.bulk_create(records)
r3_cache = {r3['name']: r3['id'] for r3 in list(RelatedField3.objects.all().values('name', 'id'))}
r2_cache = {r2['name']: r2['id'] for r2 in list(RelatedField2.objects.all().values('name', 'id'))}
r1_cache = {r1['name']: r1['id'] for r1 in list(RelatedField1.objects.all().values('name', 'id'))}

data_objects = []
for data in validated_data:
data['relfield3_id'] = r3_cache.get(data['relfield3'])
data['relfield2_id'] = r2_cache.get(data['relfield2'])
data['relfield1_id'] = r1_cache.get(data['relfield1'])
del data['relfield1'], data['relfield2'], data['relfield3']
data_objects.append(MainTable(**data))
bulk_created_list = MainTable.objects.bulk_create(data_objects)

return MainTable.objects.filter(id__in=[record.id for record in bulk_created_list]).prefetch_related(
'owner', 'relfield1', 'relfield2', 'relfield3')


class MainTableSerializer(serializers.ModelSerializer):
Expand All @@ -28,9 +30,9 @@ class Meta:

id = serializers.IntegerField(write_only=False, required=False)
owner = serializers.ReadOnlyField(source='owner.username')
relfield3 = MainTableRelatedFields(queryset=RelatedField3.objects.all())
relfield2 = MainTableRelatedFields(queryset=RelatedField2.objects.all())
relfield1 = MainTableRelatedFields(queryset=RelatedField1.objects.all())
relfield3 = serializers.CharField()
relfield2 = serializers.CharField()
relfield1 = serializers.CharField()

def create(self, validated_data):
return self.Meta.model.objects.create(**validated_data)