Skip to content

Conversation

@enozcan
Copy link
Contributor

@enozcan enozcan commented Nov 6, 2020

Adds json-smart explicitly in test scope. Otherwise, json-path comes with hazelcast-all-v4.1 excludes json-smart which is needed by the current integration tests:

with v4.0.3 hazelcast-all:

[INFO] +- com.hazelcast:hazelcast-all:jar:4.0.3:compile
[INFO] +- org.springframework.boot:spring-boot-starter-test:jar:2.3.5.RELEASE:test
[INFO] |  +- org.springframework.boot:spring-boot-test:jar:2.3.5.RELEASE:test
[INFO] |  +- org.springframework.boot:spring-boot-test-autoconfigure:jar:2.3.5.RELEASE:test
[INFO] |  +- com.jayway.jsonpath:json-path:jar:2.4.0:test
[INFO] |  |  +- net.minidev:json-smart:jar:2.3:test <<<<<<<<<<<<<<<<<<<
[INFO] |  |  |  \- net.minidev:accessors-smart:jar:1.2:test
[INFO] |  |  |     \- org.ow2.asm:asm:jar:5.0.4:test
[INFO] |  |  \- org.slf4j:slf4j-api:jar:1.7.30:compile

with v4.1 hazelcast-all:

[INFO] +- com.hazelcast:hazelcast-all:jar:4.1:compile
[INFO] |  +- org.apache.calcite:calcite-core:jar:1.23.0:compile
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-core:jar:2.11.3:compile
[INFO] |  |  \- org.apache.commons:commons-lang3:jar:3.10:runtime
[INFO] |  +- org.apache.calcite:calcite-linq4j:jar:1.23.0:compile
[INFO] |  +- org.apache.calcite.avatica:avatica-core:jar:1.16.0:compile
[INFO] |  +- com.jayway.jsonpath:json-path:jar:2.4.0:runtime  <<<<<<<<<<<<<<<<<<<
[INFO] |  +- commons-codec:commons-codec:jar:1.14:runtime

Copy link

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the auto detection works! I wonder if we get many issues like that from users ;)

Co-authored-by: Rafał Leszko <rafal@hazelcast.com>
@enozcan enozcan merged commit 6bad183 into master Nov 6, 2020
@enozcan enozcan deleted the verison-4.1 branch November 6, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants