Fix java version check in start-rc.sh #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Linux test PASSed. |
1 similar comment
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
1 similar comment
Contributor
|
Windows test PASSed. |
ihsandemir
reviewed
Apr 30, 2021
Collaborator
ihsandemir
left a comment
ihsandemir
left a comment
There was a problem hiding this comment.
What about windows start-rc.bat script?
…/hazelcast-cpp-client into fix-java-version-check
Contributor
|
Linux test FAILed. |
Contributor
Author
|
verify-linux |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test PASSed. |
ihsandemir
approved these changes
May 3, 2021
Contributor
Author
|
verify-linux |
Contributor
|
Linux test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test PASSed. |
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor issue with the Java version check I added to the start-rc.sh script in #845: turns out some JDKs print the version differently.
E.g. The JDK on my computer prints
java version "1.8.xx", JDK on the GA macos runner printsopenjdk version "1.8.xx". This change should generalize to both.