CP Subsystem - Semaphore #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
cp-semaphore
branch
from
9581800 to
155d7bf
Compare
Implementation, tests, documentation and code samples for both the session aware and sessionless semaphore proxies are added. Also, another test dependency to parameterize tests is added.
mdumandag
force-pushed
the
cp-semaphore
branch
from
155d7bf to
e188f3f
Compare
puzpuzpuz
approved these changes
Nov 3, 2020
hazelcast/proxy/cp/semaphore.py
Outdated
| "from the same thread." % self._object_name) | ||
| raise error | ||
| except Exception as e: | ||
| self._release_session(session_id) |
There was a problem hiding this comment.
I don't see this release session logic in Java client's SessionAwareSemaphoreProxy. Is it a leftover? If so, it makes sense to submit a PR to fix it in Java client and apply the change to other clients as well.
The same question applies to other methods with except Exception as e clause, like _do_drain.
Contributor
Author
There was a problem hiding this comment.
These are not leftovers, I forgot to send a PR to the Java side. I will do that and share the links within the team channel so that it can be applied to other clients. I also found that I was removing only 1 permit in case of an unspecified error on _do_acquire. Also fixed that and updated the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation, tests, documentation and code samples for both the
session aware and sessionless semaphore proxies are added.
Also, another test dependency to parameterize tests is added.