Remove logging on sending each client message #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not really useful for the end user to see the each message that clients send. It might be useful for us on some occasions, so I left it as a commented line. Commenting it resulted in approx. %1-2 throughput increase.
mdumandag
force-pushed
the
unnecessary-logging
branch
from
efe6555 to
29d3c0d
Compare
puzpuzpuz
approved these changes
Nov 18, 2020
|
I'd prefer to remove the line completely or log the message only when debug level is on, but I'm fine with the proposed change too. |
mdumandag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not really useful for the end user to see the each message
that clients send. It might be useful for us on some occasions,
so I left it as a commented line. Commenting it resulted in
approx. %1-2 throughput increase.