Make ListenerService return Future #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listener service was waiting for the result of the future in a blocking way and, returning the registration id string. This is not in line with our other APIs in which we provide non-blocking API. Also, the slight behaviour change applied to Java client is ported to Python client. hazelcast/hazelcast#17646
mdumandag
force-pushed
the
listener-service
branch
from
1390b58 to
f564ce1
Compare
mdumandag
force-pushed
the
listener-service
branch
from
02193a5 to
71319c7
Compare
puzpuzpuz
approved these changes
Nov 20, 2020
Contributor
Author
|
Thanks a lot for the review Andrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listener service was waiting for the result of the future
in a blocking way and, returning the registration id string.
This is not in line with our other APIs in which we provide
non-blocking API.
Also, the slight behaviour change applied to Java client is
ported to Python client. hazelcast/hazelcast#17646