Avoid possible race on BackupAcksTest #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be the case that the replica node could not finish its partition table initialization when it receives the backup operation request from the primary node. That can cause the backup request to be dropped which can result in test failure since there won't be any backup acks from the replica node. This won't be needed when the hazelcast/hazelcast#9398 is fixed. Until then, a call like `map.get(1)` should be enough as a workaround. See Also: hazelcast/hazelcast-nodejs-client#693
puzpuzpuz
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be the case that the replica node could not finish its
partition table initialization when it receives the backup operation
request from the primary node. That can cause the backup request to
be dropped which can result in test failure since there won't be any
backup acks from the replica node.
This won't be needed when the hazelcast/hazelcast#9398
is fixed. Until then, a call like
map.get(1)should be enough as aworkaround.
See Also: hazelcast/hazelcast-nodejs-client#693