Skip to content

Fix invocation retry mechanism #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Fix invocation retry mechanism #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
801e29f
Fix invocation retry mechanism
mdumandag Dec 17, 2020
57ceb0c
fix test_listener_re_register
mdumandag Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hazelcast/invocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def _notify_error(self, invocation, error):

def _should_retry(self, invocation, error):
if invocation.connection and isinstance(error, (IOError, TargetDisconnectedError)):
return True
return False

if invocation.uuid and isinstance(error, TargetNotMemberError):
return False
Expand Down
4 changes: 2 additions & 2 deletions tests/reconnect_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def test_listener_re_register(self):
"cluster_connect_timeout": 5.0,
})

map = client.get_map("map")
map = client.get_map("map").blocking()

collector = event_collector()
reg_id = map.add_entry_listener(added_func=collector)
Expand All @@ -83,7 +83,7 @@ def assert_events():
if client.lifecycle_service.is_running():
while True:
try:
map.put("key-%d" % count.get_and_increment(), "value").result()
map.put("key-%d" % count.get_and_increment(), "value")
break
except TargetDisconnectedError:
pass
Expand Down