Use the same correlation id on invocation retries #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using a new correlation id on invocation retries, which can cause problems because the invocation is modified in-place. We may have pending invocation entries with the key of correlation id of X while the correlation id we would get from the client message of the invocation is Y (Y > X). It is changed so that the invocation is retried but now uses the same correlation id.
puzpuzpuz
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a new correlation id on invocation retries, which
can cause problems because the invocation is modified in-place.
We may have pending invocation entries with the key of correlation
id of X while the correlation id we would get from the client
message of the invocation is Y (Y > X).
It is changed so that the invocation is retried but now uses the
same correlation id.