Get rid of the unnecessary newlines in the README #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
approved these changes
Dec 18, 2020
As pointed out in the code review for hazelcast#266, there were unnecessary newlines around the top-level callback function definition, but we left it as it is since PEP8 recommends such newlines. Changed that part to use lambdas so that we can get rid of the newlines.
mdumandag
force-pushed
the
readme-code-sample
branch
from
03e275f to
56a5a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in the code review for #266, there were
unnecessary newlines around the top-level callback function
definition, but we left it as it is since PEP8 recommends
such newlines.
Changed that part to use lambdas so that we can get rid of
the newlines.