Fail fast on the METADATA group name for CP data structures [API-389] #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible to run the CP data structures on the metadata group name. We now fail-fast if someone tries to use the `METADATA` as the CP group name. Also, the group name comparison made case-insensitive.
mdumandag
force-pushed
the
cp-metadata-group-name
branch
from
69cfbeb to
3cc15a3
Compare
srknzl
approved these changes
Mar 24, 2021
Contributor
srknzl
left a comment
srknzl
left a comment
There was a problem hiding this comment.
Looking good. I wonder why metadata cannot be used as group name
Contributor
Author
|
See https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/cp/CPGroup.java#L37, it is used by Hazelcast internally |
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to run the CP data structures on the metadata
group name. We now fail-fast if someone tries to use the
METADATAas the CP group name. Also, the group name comparison made
case-insensitive.
Closes #374