Do not use deprecated abstract classes from collections [API-388] #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract classes Sequence and Iterable are meant to be imported from `collections.abc` instead of `collections` starting from Python 3.3. Since the minimum supported Python version for the client is 3.4, we can safely try to import it from the new location and fallback to the old location if the import fails. It will only fail for the Python 2.7 in which it is fine to import those abstact classes from `collections`.
srknzl
approved these changes
Mar 24, 2021
Contributor
srknzl
left a comment
srknzl
left a comment
There was a problem hiding this comment.
Can you reproduce the warning in the issue? I could not do it.
Contributor
Author
|
Strangely, I also cannot reproduce the warning (tested on python 3.6, 3.7, and 3.9) and our nightly python 3.9 test runner works just fine but I see that it is merged in python/cpython@ef092fe Anyways, let's use this version just to be sure |
tlusk
pushed a commit
to carbonblack/hazelcast-python-client
that referenced
this pull request
Apr 15, 2021
Abstract classes Sequence and Iterable are meant to be imported from `collections.abc` instead of `collections` starting from Python 3.3. Since the minimum supported Python version for the client is 3.4, we can safely try to import it from the new location and fallback to the old location if the import fails. It will only fail for the Python 2.7 in which it is fine to import those abstact classes from `collections`.
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract classes Sequence and Iterable are meant to be imported
from
collections.abcinstead ofcollectionsstarting fromPython 3.3. Since the minimum supported Python version for the
client is 3.4, we can safely try to import it from the new location
and fallback to the old location if the import fails. It will only
fail for Python 2.7 in which it is fine to import those abstract
classes from
collections.Closes #384