Simplify connection manager [API-390] #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the Java-side fix, we now use the member UUID as the source of the truth and allow connections to be opened to the same address more than once. We just make sure that, on the active connections dictionary, there is just one entry per member via its UUID. This change simplifies a great deal of things. We now, don't need a dictionary for pending connections and managing the state of the connection manager is easier. Also, with this change, we now make sure that, for the same member, we don't have more than one active connection in the case of the issue reported on the Java-side PR. Also, improved the logging in case of the connection errors.
sancar
approved these changes
Apr 5, 2021
mdumandag
force-pushed
the
simplify-connection-manager
branch
from
7a710ac to
d3b60c8
Compare
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the Java-side fix, we now use the member UUID as the source
of the truth and allow connections to be opened to the same address
more than once. We just make sure that, on the active connections
dictionary, there is just one entry per member via its UUID.
This change simplifies a great deal of things. We now, don't need
a dictionary for pending connections and managing the state of
the connection manager is easier. Also, with this change, we now
make sure that, for the same member, we don't have more than one
active connection in the case of the issue reported on the Java-side
PR.
Also, improved the logging in case of the connection errors.
Closes #333
Closes #378