Properly shutdown clients in reconnect tests #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client shutdown call were missing for the some of the reconnect tests. Added that and added a secondary shutdown mechanism in case something goes wrong in the tests (like assertion failures) and we couldn't shutdown the client.
srknzl
approved these changes
Apr 21, 2021
Contributor
srknzl
left a comment
srknzl
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 Left a question and a nit
Comment on lines
+283
to
+285
|
|
||
| client.shutdown() | ||
| self.rc.terminateCluster(cluster.id) |
Contributor
There was a problem hiding this comment.
how was the client shutting down before this added?
Contributor
Author
There was a problem hiding this comment.
It was not :D That was the problem
Contributor
There was a problem hiding this comment.
ok that question was to clarify 😄 , thanks
Comment on lines
256
to
+258
|
|
||
| self.client = client | ||
|
|
Contributor
There was a problem hiding this comment.
nit: could do this as well (same for other self.client = client):
self.client = HazelcastClient(
cluster_name=cluster.id,
cluster_members=[client_address],
cluster_connect_timeout=sys.maxsize,
)
Contributor
Author
There was a problem hiding this comment.
Then I head to reference them as self.client instead of client, which I don't like
Contributor
Author
|
Thanks for the review Serkan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client shutdown calls were missing for some of the reconnect tests.
Added that and added a secondary shutdown mechanism in case something
goes wrong in the tests (like assertion failures) and we couldn't shutdown
the client.