[API-339] Implement ReliableTopic #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failed since the SSL certificates we used are expired now. Will send a separate PR for them once the Hazelcast Enterprise side is merged and then I will restart these tests |
… to the listener service
…destroyed_error, test_distributed_object_destroyed, test_stale
Implemented ReliableTopic on top of the Ringbuffer. Like the interface provided in the Java-side, we are offering methods to add/remove listeners and publish messages in batches or one by one. The provided API is non-blocking just like the other parts of the client. Documentation and code samples will be sent in a separate PR.
mdumandag
force-pushed
the
reliable-topic
branch
from
bb148b7 to
c994ae1
Compare
sancar
reviewed
Apr 27, 2021
| return -1 | ||
|
|
||
| def store_sequence(self, sequence): | ||
| sequences.append(sequence) |
Contributor
There was a problem hiding this comment.
Can you add a test like above to see store and retrieve is working correctly?
Contributor
Author
There was a problem hiding this comment.
Added the same test
sancar
approved these changes
Apr 27, 2021
degerhz
changed the title
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ReliableTopic on top of the Ringbuffer. Like the
interface provided in the Java-side, we are offering methods
to add/remove listeners and publish messages in batches or
one by one. The provided API is non-blocking just like the
other parts of the client.
Documentation and code samples will be sent in a separate PR.
Thanks a lot to @buraksezer for the initial version of this PR
which we used as a base for this feature.