Skip to content

custom serialization look-up fail for classes with subtype #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2017
Merged

custom serialization look-up fail for classes with subtype #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hazelcast/serialization/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def safe_register_serializer(self, stream_serializer, obj_type=None):
return current is None

def register_from_super_type(self, obj_type, super_type):
serializer = self._type_dict[super_type]
serializer = self._type_dict.get(super_type, None)
if serializer is not None:
self.safe_register_serializer(serializer, obj_type)
return serializer
Expand Down
4 changes: 2 additions & 2 deletions run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ else
USER=""
fi

HAZELCAST_VERSION="3.7.5-SNAPSHOT"
HAZELCAST_VERSION="3.8-SNAPSHOT"

HAZELCAST_RC_VERSION="0.1-SNAPSHOT"
HAZELCAST_RC_VERSION="0.2-SNAPSHOT"
SNAPSHOT_REPO="https://oss.sonatype.org/content/repositories/snapshots"
RELEASE_REPO="http://repo1.maven.apache.org/maven2"

Expand Down
4 changes: 2 additions & 2 deletions start-rc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ else
USER=""
fi

HAZELCAST_VERSION="3.7.5-SNAPSHOT"
HAZELCAST_VERSION="3.8-SNAPSHOT"

HAZELCAST_RC_VERSION="0.1-SNAPSHOT"
HAZELCAST_RC_VERSION="0.2-SNAPSHOT"
SNAPSHOT_REPO="https://oss.sonatype.org/content/repositories/snapshots"
RELEASE_REPO="http://repo1.maven.apache.org/maven2"

Expand Down
7 changes: 7 additions & 0 deletions tests/serialization/serialization_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ def test_python_pickle_serialization(self):
obj2 = self.service.to_object(data)
self.assertEqual(obj, obj2)

def test_python_pickle_serialization_with_super_type(self):
obj = {"key-%d" % x: "value-%d" % x for x in xrange(0, 1000)}
data = self.service.to_data(obj)

obj2 = self.service.to_object(data)
self.assertEqual(obj, obj2)

def test_null_data(self):
data = Data()
obj = self.service.to_object(data)
Expand Down