fix pop behaviour of connection manager #96
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
mdumandag
force-pushed
the
connection-pop-fix
branch
from
cd5d049 to
bf770eb
Compare
mdumandag
force-pushed
the
connection-pop-fix
branch
from
bf770eb to
8a2fd27
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
1 similar comment
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests FAILed. |
Contributor
Author
|
verify |
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
asimarslan
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When client authenticates with the same address more than once, connections and _pending_connections dictionaries of the connection manager are updated with the latests address-future pair as it should be. However, when on_auth or _connection_closed methods are called for each connection, these methods try to pop the same address from these dictionaries more than once which results in a KeyError.
We should try to pop the address but when KeyError happens we should simply pass since that address is already removed from these dictionaries by the previous method calls.