Skip to content

Conversation

@kobrikx
Copy link
Contributor

@kobrikx kobrikx commented Dec 2, 2024

What's new:

  • Module created

Testing done

Deploy successful:
Screenshot 2024-12-02 at 17 32 11

Parameters created:
Screenshot 2024-12-03 at 20 01 28

Parameter:
Screenshot 2024-12-03 at 20 55 45

@kobrikx kobrikx requested a review from DimmKirr December 2, 2024 21:45
@DimmKirr
Copy link
Contributor

DimmKirr commented Dec 2, 2024

@kobrikx Let's add Terraform linter?

@kobrikx kobrikx force-pushed the CORE-774-aws-ssm-parameter-store-module-created branch from adc19c3 to fa608b8 Compare December 2, 2024 22:23
@kobrikx kobrikx force-pushed the CORE-774-aws-ssm-parameter-store-module-created branch from fa608b8 to c0e8575 Compare December 2, 2024 22:26
Copy link
Contributor

@DimmKirr DimmKirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!
Please address my notes.
(Sorry forgot to post yesterday)

@kobrikx kobrikx requested a review from DimmKirr December 3, 2024 18:25
Copy link
Contributor

@DimmKirr DimmKirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please address my changes and re-submit review.
LMK if you have questions

@kobrikx kobrikx requested a review from DimmKirr December 4, 2024 12:14
Copy link
Contributor

@DimmKirr DimmKirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kobrikx kobrikx merged commit 369df5d into main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants