Skip to content

Conversation

@Kannndev
Copy link
Contributor

@Kannndev Kannndev commented Aug 20, 2020

Closes #104

@harshzalavadiya
Copy link
Member

Hi @Kannndev,

Sorry for late response, I have updated few things in PR

  • SVG as a fallback instead of unicode charactor
  • Converted <span/> to <button/> element
  • added aria-label w/ new key in i18n string since using unicode char or svg may cause problems for screen readers
  • ClearIcon prop also accepts simple string as well as a param by default

@harshzalavadiya harshzalavadiya merged commit 75e5e8c into hc-oss:master Sep 4, 2020
@Kannndev
Copy link
Contributor Author

Kannndev commented Sep 4, 2020

Thanks @harshzalavadiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search Clear Icon not showing

2 participants