Skip to content

Implement onMenuToggle feature #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

Implement onMenuToggle feature #19

merged 1 commit into from
May 6, 2020

Conversation

@porteron
Copy link
Contributor

@porteron porteron commented May 6, 2020 •
edited by harshzalavadiya
Loading

Closes #16

  • Implemented an onMenuToggle boolean the user can use for both open and closed state of dropdown.

@porteron porteron mentioned this pull request May 6, 2020
Closed
porteron
porteron commented May 6, 2020
View reviewed changes
Copy link
Contributor Author

@porteron porteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

porteron
porteron commented May 6, 2020
View reviewed changes
Copy link
Contributor Author

@porteron porteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@harshzalavadiya harshzalavadiya force-pushed the feature/onMenuToggle branch from 8201aab to 02b7fe8 Compare May 6, 2020 20:50
@harshzalavadiya harshzalavadiya merged commit e7cf43b into hc-oss:master May 6, 2020
@harshzalavadiya
Copy link
Member

harshzalavadiya commented May 6, 2020

Hi @mnoster ,

Thank you for revised PR, everything looks good I just rebased it for minor changes and merged to master

@porteron
Copy link
Contributor Author

porteron commented May 6, 2020

Thanks! @harshzalavadiya
I will now be using this in my app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for onBlur and onClose events

2 participants

@porteron @harshzalavadiya