Skip to content

Conversation

@breynolds-dev
Copy link
Contributor

resolves #317

Summary of Changes:

  • Added new stories to show rendering strings (and array of strings) as well as elements
  • Updated valueRenderer to accept ReactNode instead of string (ReactNode accepts a larger variety of things that can be rendered in the place of just a string:
type ReactText = string | number;
type ReactChild = ReactElement | ReactText;

interface ReactNodeArray extends Array<ReactNode> {}
type ReactFragment = {} | ReactNodeArray;

type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;

@harshzalavadiya
Copy link
Member

@breynolds-dev this is great, just an small typo in file name 'stories/customm-element.stories.tsx' and this should be ready to merge

@breynolds-dev
Copy link
Contributor Author

breynolds-dev commented Mar 2, 2021

wow, how embarrassing. I will get this updated and pushed

Edit: I fixed the typo and squashed the commits back down

@harshzalavadiya harshzalavadiya merged commit f21701a into hc-oss:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: custom trigger element

2 participants