Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/hooks/use-did-update-effect.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { useEffect, useRef } from "react";

/**
* similar to `useEffect` but gets triggered only when value changes
* @param fn executable function on dependency updates
* @param inputs dependency array
*/
export function useDidUpdateEffect(fn, inputs) {
const didMountRef = useRef(false);

useEffect(() => {
if (didMountRef.current) fn();
else didMountRef.current = true;
}, inputs);
}
4 changes: 2 additions & 2 deletions src/multi-select/dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import { css } from "goober";
import React, { useEffect, useRef, useState } from "react";

import { useDidUpdateEffect } from "../hooks/use-did-update-effect";
import { useMultiSelect } from "../hooks/use-multi-select";
import { cn } from "../lib/classnames";
import SelectPanel from "../select-panel";
Expand Down Expand Up @@ -89,8 +90,7 @@ const Dropdown = () => {

const wrapper: any = useRef();

/* eslint-disable react-hooks/exhaustive-deps */
useEffect(() => {
useDidUpdateEffect(() => {
onMenuToggle && onMenuToggle(expanded);
}, [expanded]);

Expand Down
1 change: 1 addition & 0 deletions stories/custom-arrow.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const ExampleCustomArrow = () => {
onChange={setSelected}
labelledBy={text("labelledBy", "Select Fruits")}
ArrowRenderer={ArrowRenderer}
onMenuToggle={(isOpen) => console.log("onMenuToggle", isOpen)}
/>
</div>
);
Expand Down