-
-
Notifications
You must be signed in to change notification settings - Fork 95
New field feature enable in multi select when search text doesn't match any option #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/harshzalavadiya/react-multi-select-component/FWhTqxPWu7z9Kyvh57JPhSLq3ohv |
|
@jorge-cob Thank you for the PR however few points
|
|
@harshzalavadiya thanks for the feedback. Here a list of changes made to original PR:
|
|
@jorge-cob I have made few changes and added docs but I'm not able to push the changes into this PR, can you enable allow edit from maintainers option? also sorry for late response, I have been bit busy lately so :P |
|
@harshzalavadiya edits by maintainers was already enabled. Maybe it's something else? |
|
@jorge-cob thanks for checking out, no issues, I'll merge this with another local branch |
* New field feature enable in multi select when search text doesn't match any option (#416) * New field feature enable in multi select * Changes in response to PR comment * refactor: ♻️ cleanup + docs Co-authored-by: Jorge Cobreros <jorge.cobreros@protonmail.com>
|
released |
When search criteria does not match any option, a feature can be enabled that will show a button allowing to handle a given function. In the Storybook's example the function passed will set a new state with the given item.
Might be interesting to even allow customization of the icon and the label.