Skip to content

fix: 🐛 filter selection #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

fix: 🐛 filter selection #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ More examples can be found [here ↗](./docs/recipes)
| `overrideStrings` | [localization ↗](docs/recipes/localization.md) | `object` | |
| `onChange` | onChange callback | `function` | |
| `disabled` | disable dropdown | `boolean` | `false` |
| `selectAllLabel` | _select all_ label | `string` | |
| `disableSearch` | hide search textbox | `boolean` | `false` |
| `filterOptions` | [custom filter options (async supported) ↗](docs/recipes/custom-filter.md) | `function` | Fuzzy Search |
| `className` | class name for parent component | `string` | `multi-select` |
Expand Down
1 change: 1 addition & 0 deletions src/hooks/use-multi-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const defaultStrings = {
noOptions: "No options",
search: "Search",
selectAll: "Select All",
selectAllFiltered: "Select All (Filtered)",
selectSomeItems: "Select...",
create: "Create",
};
Expand Down
1 change: 0 additions & 1 deletion src/lib/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export interface ISelectProps {
valueRenderer?: (selected: Option[], options: Option[]) => ReactNode;
ItemRenderer?;
ArrowRenderer?: ({ expanded }) => JSX.Element;
selectAllLabel?: string;
isLoading?: boolean;
disabled?: boolean;
disableSearch?: boolean;
Expand Down
7 changes: 2 additions & 5 deletions src/select-panel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const SelectPanel = () => {
setOptions,
value,
filterOptions: customFilterOptions,
selectAllLabel,
ItemRenderer,
disabled,
disableSearch,
Expand Down Expand Up @@ -65,7 +64,7 @@ const SelectPanel = () => {
}, [disableSearch, hasSelectAll]);

const selectAllOption = {
label: selectAllLabel || t("selectAll"),
label: searchText ? t("selectAllFiltered") : t("selectAll"),
value: "",
};

Expand All @@ -78,9 +77,7 @@ const SelectPanel = () => {
const selectedValues = value.map((o) => o.value);
const finalSelectedValues = [...selectedValues, ...filteredValues];

return filteredOptions.filter((o) =>
finalSelectedValues.includes(o.value)
);
return options.filter((o) => finalSelectedValues.includes(o.value));
}

return value.filter((o) => !filteredValues.includes(o.value));
Expand Down