refactor: use standard rpc style #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/swagger/campusapis/health/v1/health.swagger.json # docs/swagger/consultingapis/faq/v1/faq.swagger.json
|
打算什么时候合并 |
|
需要所有相关依赖服务都迁移至新的proto定义且完成测试 |
# Conflicts: # campusapis/staff/v1/campus.pb.go # campusapis/staff/v1/campus.pb.gw.go # campusapis/staff/v1/campus.proto # campusapis/staff/v1/campus_grpc.pb.go # docs/swagger/campusapis/staff/v1/campus.swagger.json
# Conflicts: # aggregatingapis/infostream/v1/infostream.pb.go
…to dev-standard-rpc
|
@fdkevin0 给前端的数据多包了一层怎么处理，是在gateway之类的地方把外壳脱了还是直接让前端改 |
什么叫多包了一层，给一个样例 |
哦哦懂了，之前理解错了 |
# Conflicts: # campusapis/staff/v1/campus.pb.go # docs/swagger/campusapis/staff/v1/campus.swagger.json
|
有亿点review不动😥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.