Improve download_progress example#283
Merged
hecrj merged 9 commits intoiced-rs:masterfrom Feb 12, 2021
Merged
Conversation
Member
|
Looks cool! 🎉 I think we should add progress bars and merge the example with the |
Folyd
changed the title
Contributor
Author
|
@hecrj I have added progress bar and replaced the old download example with this one. Is it ok to be merged? |
hecrj
requested changes
Apr 27, 2020
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Looks great!
Before merging, I believe we need to focus on simplifying the example a bit.
Contributor
Author
|
@hecrj Thanks for reviewing. :) |
hecrj
approved these changes
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like we have no example to demonstrate the powerful strength of
Subscription.batch()API. So this is why I add this example. I know we already have a nice download example that has some duplicate code with this one. I still think we deserve such an example to instruct the new user to handle multiple asynchronous commands withSubscription.batch(). Maybe we can merge two download examples into a single one and distinct with different modes (simple and advanced)?