Update to wgpu 0.7#725
Merged
hecrj merged 16 commits intoiced-rs:masterfrom Feb 6, 2021
PolyMeilex:wgpu-7.0
Merged
Conversation
Notes: - wgpu::PowerPreference::Default no longer exists, maybe there is another way to replicate its behavior.
Notes: - not sure if `filtering sampler` should be used, so for now it is not used .
- Breaks `TODO: Address anti-aliasing adjustments properly`
wgpu validation helped to find this long standing type error
PolyMeilex
commented
Feb 3, 2021
PolyMeilex
commented
Feb 3, 2021
There is no reason to hide the fact that this is always in `LowPower` mode
hecrj
approved these changes
Feb 6, 2021
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
This is great! Thank you! 🎉
I have made some changes to fix a couple of details, but overall everything looks good! The most important ones are:
- 5fc4210 which changes the
wgpu_glyphdependency to rely on the latest release. - 74b9ea5 which enables the filtering flags in
wgpu::image, since we use bilinear filtering there. I am not sure if this is correct, however. I didn't see any validation errors nor a difference in the rendered image.
In any case, I think we can merge this!
Contributor
Author
|
Thanks |
This was referenced Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
wgpu::PowerPreference::Defaultno longer exists, maybe there is another way to replicate its behavior.filtering samplershould be used. (so it is not used)What is working:
Closes #723.