Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prebuilt packages for ArchLinux #8

Closed
StefanescuCristian opened this issue Jan 27, 2019 · 38 comments
Closed

Add prebuilt packages for ArchLinux #8

StefanescuCristian opened this issue Jan 27, 2019 · 38 comments

Comments

@StefanescuCristian
Copy link

Hello,

In ArchLinux AUR, there is a package you can build the kernel from your kernel source. The time compiling this on our laptop is huge on today's standards, so I have built them on another machine and installed on our little laptop.

I have made this packages public and I'll try to maintain them as much as I can and the time permits, but since there are two big distro users who are building from your sources (Debian and Arch) and you already release binaries for one of them (Debian) are you interested in adding the binaries I compiled to your releases page?

I think adding the Arch kernels here will be easier for users to find them.

If you are interested, you can find the files here.

@heikomat
Copy link
Owner

I'm definitely interested in supporting arch linux the same way debian is supported (in the best case scenario even through the same install-script)

I currently build the debian kernel packages in a docker container (see here). I haven't yet had the time to create a similar (working) docker container for arch, but having the config files necessary to build the kernel packages will definitely help me, as i haven't actually used arch yet.

I'm currently busy studying for exams, but will come back to this issue when i have the time and patience to do so.

If you happen to know your way around docker, and have the time to do so, you could help me with this, if you want to

@StefanescuCristian
Copy link
Author

Cool,

I'll try to write a Dockerfile for Arch and make a PR.

@heikomat
Copy link
Owner

heikomat commented Jan 27, 2019

cool, thanks :D
For debian, there are two files on the docker_builds-branch: Dockerfile_debian and build_debian.sh.

When executing ./build_debian.sh, it creates the container according to the Dockerfile_debian, which builds the kernel packages, then copies the resulting packages to the host system and deletes the container. I then upload these packages to a new github-release and adjust the version-number in the installer script

The analogous files for arch (Dockerfile_arch and build_arch.sh) already exist on that branch, but are as of now just copies of the debian-files and don't work.

If you could edit these files in a way that would make them build the working arch-packages and put them on the host machine (just like the debian version), that would be really epic :D

@StefanescuCristian
Copy link
Author

I've made PR #9

It worked for me, but you should give it a try to see if you manage to get the linux*.xz files.
It was fun to play around with docker. I still don't like it, but was a nice weekend project 😆

@heikomat
Copy link
Owner

Well, docker allows me to build the kernel on my macbook without dualbooting and guarantees that the kernel-build-environment is independent of the host machine, so that it works the same everywhere.

I'm glad it was a nice project for you :)

@7twin
Copy link

7twin commented Apr 22, 2019

@heikomat I have actually polished my docker knowledge through multiple projects since we last had this topic and came up with my own Dockerfile/Compose now, it built the 5.0 branch just fine too.

I'll make it into an interactive script, then link it here, the only difference is that I build based on the same instructions posted here: https://github.com/7twin/arch_sound_e200ha so after it has done building, you transfer the zip that got volume mounted onto the e200ha, unzip and install it. (could have a script for that too, I'll see how fancy it'll end up being)

Just need some more available time on my hands to compile it all together and test if the build that went through fine, is also actually bootable. (saw you guys had some issues in the previous docker PR)

@StefanescuCristian
Copy link
Author

Hello,

I've forgot about this, sorry. I never got to update the PR, because life happens sometimes.

@7twin You can use my dockerfile as a template/example and modify it you think it helps. I've commented almost every command and I think it's easy enough to understand it.

@7twin
Copy link

7twin commented Apr 22, 2019

@StefanescuCristian Don't worry, we all have our fair share of life, so things do move slow sometimes. As mentioned once I have some more time on my hands I'll test if the build is bootable and create also interactive scripts for it. ☺️

@heikomat
Copy link
Owner

Nice to hear that you guys are still on it :)
@7twin the 5.0-branch is not merged yet, because when i docker-buillt it for debian/ubuntu the same way i built 4.20, the laptop wasn't booting anymore. I need a free evening to debug this and see why this happens.
Have no plans for the weekend yet. If it stays that way, i'll try to fix the 5.0-branch

@7twin
Copy link

7twin commented Apr 23, 2019

@heikomat I should also have some time available soon'ish. I have already generated 3 zip files, each in different size depending on how many cores I built it (not sure why, e.g. on 32 cores it built to a zipped 450MB where as on 16 it built to 746~MB). I will try if any of those work to boot from and report back, though if you building as "usual" made it not boot, then something more major might be wrong.

@7twin
Copy link

7twin commented May 1, 2019

@heikomat had finally time to test it, doesn't seem to boot for me either, even though the docker build itself worked.

heikomat pushed a commit that referenced this issue May 19, 2019
Syzkaller report this:

pf: pf version 1.04, major 47, cluster 64, nice 0
pf: No ATAPI disk detected
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN PTI
CPU: 0 PID: 9887 Comm: syz-executor.0 Tainted: G         C        5.1.0-rc3+ #8
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
RIP: 0010:pf_init+0x7af/0x1000 [pf]
Code: 46 77 d2 48 89 d8 48 c1 e8 03 80 3c 28 00 74 08 48 89 df e8 03 25 a6 d2 4c 8b 23 49 8d bc 24 80 05 00 00 48 89 f8 48 c1 e8 03 <80> 3c 28 00 74 05 e8 e6 24 a6 d2 49 8b bc 24 80 05 00 00 e8 79 34
RSP: 0018:ffff8881abcbf998 EFLAGS: 00010202
RAX: 00000000000000b0 RBX: ffffffffc1e4a8a8 RCX: ffffffffaec50788
RDX: 0000000000039b10 RSI: ffffc9000153c000 RDI: 0000000000000580
RBP: dffffc0000000000 R08: ffffed103ee44e59 R09: ffffed103ee44e59
R10: 0000000000000001 R11: ffffed103ee44e58 R12: 0000000000000000
R13: ffffffffc1e4b028 R14: 0000000000000000 R15: 0000000000000020
FS:  00007f1b78a91700(0000) GS:ffff8881f7200000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f6d72b207f8 CR3: 00000001d5790004 CR4: 00000000007606f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 ? 0xffffffffc1e50000
 do_one_initcall+0xbc/0x47d init/main.c:901
 do_init_module+0x1b5/0x547 kernel/module.c:3456
 load_module+0x6405/0x8c10 kernel/module.c:3804
 __do_sys_finit_module+0x162/0x190 kernel/module.c:3898
 do_syscall_64+0x9f/0x450 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x462e99
Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1b78a90c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
RAX: ffffffffffffffda RBX: 000000000073bf00 RCX: 0000000000462e99
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000003
RBP: 00007f1b78a90c70 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f1b78a916bc
R13: 00000000004bcefa R14: 00000000006f6fb0 R15: 0000000000000004
Modules linked in: pf(+) paride gpio_tps65218 tps65218 i2c_cht_wc ati_remote dc395x act_meta_skbtcindex act_ife ife ecdh_generic rc_xbox_dvd sky81452_regulator v4l2_fwnode leds_blinkm snd_usb_hiface comedi(C) aes_ti slhc cfi_cmdset_0020 mtd cfi_util sx8654 mdio_gpio of_mdio fixed_phy mdio_bitbang libphy alcor_pci matrix_keymap hid_uclogic usbhid scsi_transport_fc videobuf2_v4l2 videobuf2_dma_sg snd_soc_pcm179x_spi snd_soc_pcm179x_codec i2c_demux_pinctrl mdev snd_indigodj isl6405 mii enc28j60 cmac adt7316_i2c(C) adt7316(C) fmc_trivial fmc nf_reject_ipv4 authenc rc_dtt200u rtc_ds1672 dvb_usb_dibusb_mc dvb_usb_dibusb_mc_common dib3000mc dibx000_common dvb_usb_dibusb_common dvb_usb dvb_core videobuf2_common videobuf2_vmalloc videobuf2_memops regulator_haptic adf7242 mac802154 ieee802154 s5h1409 da9034_ts snd_intel8x0m wmi cx24120 usbcore sdhci_cadence sdhci_pltfm sdhci mmc_core joydev i2c_algo_bit scsi_transport_iscsi iscsi_boot_sysfs ves1820 lockd grace nfs_acl auth_rpcgss sunrp
 c
 ip_vs snd_soc_adau7002 snd_cs4281 snd_rawmidi gameport snd_opl3_lib snd_seq_device snd_hwdep snd_ac97_codec ad7418 hid_primax hid snd_soc_cs4265 snd_soc_core snd_pcm_dmaengine snd_pcm snd_timer ac97_bus snd_compress snd soundcore ti_adc108s102 eeprom_93cx6 i2c_algo_pca mlxreg_hotplug st_pressure st_sensors industrialio_triggered_buffer kfifo_buf industrialio v4l2_common videodev media snd_soc_adau_utils rc_pinnacle_grey rc_core pps_gpio leds_lm3692x nandcore ledtrig_pattern iptable_security iptable_raw iptable_mangle iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_filter bpfilter ip6_vti ip_vti ip_gre ipip sit tunnel4 ip_tunnel hsr veth netdevsim vxcan batman_adv cfg80211 rfkill chnl_net caif nlmon dummy team bonding vcan bridge stp llc ip6_gre gre ip6_tunnel tunnel6 tun mousedev ppdev tpm kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel ide_pci_generic aes_x86_64 piix crypto_simd input_leds psmouse cryp
 td
 glue_helper ide_core intel_agp serio_raw intel_gtt agpgart ata_generic i2c_piix4 pata_acpi parport_pc parport rtc_cmos floppy sch_fq_codel ip_tables x_tables sha1_ssse3 sha1_generic ipv6 [last unloaded: paride]
Dumping ftrace buffer:
  (ftrace buffer empty)
---[ end trace 7a818cf5f210d79e ]---

If alloc_disk fails in pf_init_units, pf->disk will be
NULL, however in pf_detect and pf_exit, it's not check
this before free.It may result a NULL pointer dereference.

Also when register_blkdev failed, blk_cleanup_queue() and
blk_mq_free_tag_set() should be called to free resources.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 6ce5902 ("paride/pf: cleanup queues when detection fails")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Signed-off-by: Jens Axboe <axboe@kernel.dk>
heikomat pushed a commit that referenced this issue May 19, 2019
Syzkaller report this:

pcd: pcd version 1.07, major 46, nice 0
pcd0: Autoprobe failed
pcd: No CD-ROM drive found
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN PTI
CPU: 1 PID: 4525 Comm: syz-executor.0 Not tainted 5.1.0-rc3+ #8
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
RIP: 0010:pcd_init+0x95c/0x1000 [pcd]
Code: c4 ab f7 48 89 d8 48 c1 e8 03 80 3c 28 00 74 08 48 89 df e8 56 a3 da f7 4c 8b 23 49 8d bc 24 80 05 00 00 48 89 f8 48 c1 e8 03 <80> 3c 28 00 74 05 e8 39 a3 da f7 49 8b bc 24 80 05 00 00 e8 cc b2
RSP: 0018:ffff8881e84df880 EFLAGS: 00010202
RAX: 00000000000000b0 RBX: ffffffffc155a088 RCX: ffffffffc1508935
RDX: 0000000000040000 RSI: ffffc900014f0000 RDI: 0000000000000580
RBP: dffffc0000000000 R08: ffffed103ee658b8 R09: ffffed103ee658b8
R10: 0000000000000001 R11: ffffed103ee658b7 R12: 0000000000000000
R13: ffffffffc155a778 R14: ffffffffc155a4a8 R15: 0000000000000003
FS:  00007fe71bee3700(0000) GS:ffff8881f7300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055a7334441a8 CR3: 00000001e9674003 CR4: 00000000007606e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 ? 0xffffffffc1508000
 ? 0xffffffffc1508000
 do_one_initcall+0xbc/0x47d init/main.c:901
 do_init_module+0x1b5/0x547 kernel/module.c:3456
 load_module+0x6405/0x8c10 kernel/module.c:3804
 __do_sys_finit_module+0x162/0x190 kernel/module.c:3898
 do_syscall_64+0x9f/0x450 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x462e99
Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe71bee2c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
RAX: ffffffffffffffda RBX: 000000000073bf00 RCX: 0000000000462e99
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000003
RBP: 00007fe71bee2c70 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe71bee36bc
R13: 00000000004bcefa R14: 00000000006f6fb0 R15: 0000000000000004
Modules linked in: pcd(+) paride solos_pci atm ts_fsm rtc_mt6397 mac80211 nhc_mobility nhc_udp nhc_ipv6 nhc_hop nhc_dest nhc_fragment nhc_routing 6lowpan rtc_cros_ec memconsole intel_xhci_usb_role_switch roles rtc_wm8350 usbcore industrialio_triggered_buffer kfifo_buf industrialio asc7621 dm_era dm_persistent_data dm_bufio dm_mod tpm gnss_ubx gnss_serial serdev gnss max2165 cpufreq_dt hid_penmount hid menf21bmc_wdt rc_core n_tracesink ide_gd_mod cdns_csi2tx v4l2_fwnode videodev media pinctrl_lewisburg pinctrl_intel iptable_security iptable_raw iptable_mangle iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_filter bpfilter ip6_vti ip_vti ip_gre ipip sit tunnel4 ip_tunnel hsr veth netdevsim vxcan batman_adv cfg80211 rfkill chnl_net caif nlmon dummy team bonding vcan bridge stp llc ip6_gre gre ip6_tunnel tunnel6 tun joydev mousedev ppdev kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel aes_x86_64 crypto_simd
 ide_pci_generic piix input_leds cryptd glue_helper psmouse ide_core intel_agp serio_raw intel_gtt ata_generic i2c_piix4 agpgart pata_acpi parport_pc parport floppy rtc_cmos sch_fq_codel ip_tables x_tables sha1_ssse3 sha1_generic ipv6 [last unloaded: bmc150_magn]
Dumping ftrace buffer:
   (ftrace buffer empty)
---[ end trace d873691c3cd69f56 ]---

If alloc_disk fails in pcd_init_units, cd->disk will be
NULL, however in pcd_detect and pcd_exit, it's not check
this before free.It may result a NULL pointer dereference.

Also when register_blkdev failed, blk_cleanup_queue() and
blk_mq_free_tag_set() should be called to free resources.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 81b74ac ("paride/pcd: cleanup queues when detection fails")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Signed-off-by: Jens Axboe <axboe@kernel.dk>
heikomat pushed a commit that referenced this issue May 19, 2019
By calling maps__insert() we assume to get 2 references on the map,
which we relese within maps__remove call.

However if there's already same map name, we currently don't bump the
reference and can crash, like:

  Program received signal SIGABRT, Aborted.
  0x00007ffff75e60f5 in raise () from /lib64/libc.so.6

  (gdb) bt
  #0  0x00007ffff75e60f5 in raise () from /lib64/libc.so.6
  #1  0x00007ffff75d0895 in abort () from /lib64/libc.so.6
  #2  0x00007ffff75d0769 in __assert_fail_base.cold () from /lib64/libc.so.6
  #3  0x00007ffff75de596 in __assert_fail () from /lib64/libc.so.6
  #4  0x00000000004fc006 in refcount_sub_and_test (i=1, r=0x1224e88) at tools/include/linux/refcount.h:131
  #5  refcount_dec_and_test (r=0x1224e88) at tools/include/linux/refcount.h:148
  #6  map__put (map=0x1224df0) at util/map.c:299
  #7  0x00000000004fdb95 in __maps__remove (map=0x1224df0, maps=0xb17d80) at util/map.c:953
  #8  maps__remove (maps=0xb17d80, map=0x1224df0) at util/map.c:959
  #9  0x00000000004f7d8a in map_groups__remove (map=<optimized out>, mg=<optimized out>) at util/map_groups.h:65
  #10 machine__process_ksymbol_unregister (sample=<optimized out>, event=0x7ffff7279670, machine=<optimized out>) at util/machine.c:728
  #11 machine__process_ksymbol (machine=<optimized out>, event=0x7ffff7279670, sample=<optimized out>) at util/machine.c:741
  #12 0x00000000004fffbb in perf_session__deliver_event (session=0xb11390, event=0x7ffff7279670, tool=0x7fffffffc7b0, file_offset=13936) at util/session.c:1362
  #13 0x00000000005039bb in do_flush (show_progress=false, oe=0xb17e80) at util/ordered-events.c:243
  #14 __ordered_events__flush (oe=0xb17e80, how=OE_FLUSH__ROUND, timestamp=<optimized out>) at util/ordered-events.c:322
  torvalds#15 0x00000000005005e4 in perf_session__process_user_event (session=session@entry=0xb11390, event=event@entry=0x7ffff72a4af8,
  ...

Add the map to the list and getting the reference event if we find the
map with same name.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Eric Saint-Etienne <eric.saint.etienne@oracle.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Fixes: 1e62856 ("perf symbols: Fix slowness due to -ffunction-section")
Link: http://lkml.kernel.org/r/20190416160127.30203-10-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
heikomat pushed a commit that referenced this issue May 19, 2019
Commit 51dedad ("kasan, slab: make freelist stored without tags")
calls kasan_reset_tag() for off-slab slab management object leading to
freelist being stored non-tagged.

However, cache_grow_begin() calls alloc_slabmgmt() which calls
kmem_cache_alloc_node() assigns a tag for the address and stores it in
the shadow address.  As the result, it causes endless errors below
during boot due to drain_freelist() -> slab_destroy() ->
kasan_slab_free() which compares already untagged freelist against the
stored tag in the shadow address.

Since off-slab slab management object freelist is such a special case,
just store it tagged.  Non-off-slab management object freelist is still
stored untagged which has not been assigned a tag and should not cause
any other troubles with this inconsistency.

  BUG: KASAN: double-free or invalid-free in slab_destroy+0x84/0x88
  Pointer tag: [ff], memory tag: [99]

  CPU: 0 PID: 1376 Comm: kworker/0:4 Tainted: G        W 5.1.0-rc3+ #8
  Hardware name: HPE Apollo 70             /C01_APACHE_MB         , BIOS L50_5.13_1.0.6 07/10/2018
  Workqueue: cgroup_destroy css_killed_work_fn
  Call trace:
   print_address_description+0x74/0x2a4
   kasan_report_invalid_free+0x80/0xc0
   __kasan_slab_free+0x204/0x208
   kasan_slab_free+0xc/0x18
   kmem_cache_free+0xe4/0x254
   slab_destroy+0x84/0x88
   drain_freelist+0xd0/0x104
   __kmem_cache_shrink+0x1ac/0x224
   __kmemcg_cache_deactivate+0x1c/0x28
   memcg_deactivate_kmem_caches+0xa0/0xe8
   memcg_offline_kmem+0x8c/0x3d4
   mem_cgroup_css_offline+0x24c/0x290
   css_killed_work_fn+0x154/0x618
   process_one_work+0x9cc/0x183c
   worker_thread+0x9b0/0xe38
   kthread+0x374/0x390
   ret_from_fork+0x10/0x18

  Allocated by task 1625:
   __kasan_kmalloc+0x168/0x240
   kasan_slab_alloc+0x18/0x20
   kmem_cache_alloc_node+0x1f8/0x3a0
   cache_grow_begin+0x4fc/0xa24
   cache_alloc_refill+0x2f8/0x3e8
   kmem_cache_alloc+0x1bc/0x3bc
   sock_alloc_inode+0x58/0x334
   alloc_inode+0xb8/0x164
   new_inode_pseudo+0x20/0xec
   sock_alloc+0x74/0x284
   __sock_create+0xb0/0x58c
   sock_create+0x98/0xb8
   __sys_socket+0x60/0x138
   __arm64_sys_socket+0xa4/0x110
   el0_svc_handler+0x2c0/0x47c
   el0_svc+0x8/0xc

  Freed by task 1625:
   __kasan_slab_free+0x114/0x208
   kasan_slab_free+0xc/0x18
   kfree+0x1a8/0x1e0
   single_release+0x7c/0x9c
   close_pdeo+0x13c/0x43c
   proc_reg_release+0xec/0x108
   __fput+0x2f8/0x784
   ____fput+0x1c/0x28
   task_work_run+0xc0/0x1b0
   do_notify_resume+0xb44/0x1278
   work_pending+0x8/0x10

  The buggy address belongs to the object at ffff809681b89e00
   which belongs to the cache kmalloc-128 of size 128
  The buggy address is located 0 bytes inside of
   128-byte region [ffff809681b89e00, ffff809681b89e80)
  The buggy address belongs to the page:
  page:ffff7fe025a06e00 count:1 mapcount:0 mapping:01ff80082000fb00
  index:0xffff809681b8fe04
  flags: 0x17ffffffc000200(slab)
  raw: 017ffffffc000200 ffff7fe025a06d08 ffff7fe022ef7b88 01ff80082000fb00
  raw: ffff809681b8fe04 ffff809681b80000 00000001000000e0 0000000000000000
  page dumped because: kasan: bad access detected
  page allocated via order 0, migratetype Unmovable, gfp_mask
  0x2420c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_COMP|__GFP_THISNODE)
   prep_new_page+0x4e0/0x5e0
   get_page_from_freelist+0x4ce8/0x50d4
   __alloc_pages_nodemask+0x738/0x38b8
   cache_grow_begin+0xd8/0xa24
   ____cache_alloc_node+0x14c/0x268
   __kmalloc+0x1c8/0x3fc
   ftrace_free_mem+0x408/0x1284
   ftrace_free_init_mem+0x20/0x28
   kernel_init+0x24/0x548
   ret_from_fork+0x10/0x18

  Memory state around the buggy address:
   ffff809681b89c00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
   ffff809681b89d00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
  >ffff809681b89e00: 99 99 99 99 99 99 99 99 fe fe fe fe fe fe fe fe
                     ^
   ffff809681b89f00: 43 43 43 43 43 fe fe fe fe fe fe fe fe fe fe fe
   ffff809681b8a000: 6d fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe

Link: http://lkml.kernel.org/r/20190403022858.97584-1-cai@lca.pw
Fixes: 51dedad ("kasan, slab: make freelist stored without tags")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
heikomat pushed a commit that referenced this issue May 19, 2019
Syzkaller report this:

  sysctl could not get directory: /net//bridge -12
  kasan: CONFIG_KASAN_INLINE enabled
  kasan: GPF could be caused by NULL-ptr deref or user memory access
  general protection fault: 0000 [#1] SMP KASAN PTI
  CPU: 1 PID: 7027 Comm: syz-executor.0 Tainted: G         C        5.1.0-rc3+ #8
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
  RIP: 0010:__write_once_size include/linux/compiler.h:220 [inline]
  RIP: 0010:__rb_change_child include/linux/rbtree_augmented.h:144 [inline]
  RIP: 0010:__rb_erase_augmented include/linux/rbtree_augmented.h:186 [inline]
  RIP: 0010:rb_erase+0x5f4/0x19f0 lib/rbtree.c:459
  Code: 00 0f 85 60 13 00 00 48 89 1a 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 89 f2 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 75 0c 00 00 4d 85 ed 4c 89 2e 74 ce 4c 89 ea 48
  RSP: 0018:ffff8881bb507778 EFLAGS: 00010206
  RAX: dffffc0000000000 RBX: ffff8881f224b5b8 RCX: ffffffff818f3f6a
  RDX: 000000000000000a RSI: 0000000000000050 RDI: ffff8881f224b568
  RBP: 0000000000000000 R08: ffffed10376a0ef4 R09: ffffed10376a0ef4
  R10: 0000000000000001 R11: ffffed10376a0ef4 R12: ffff8881f224b558
  R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
  FS:  00007f3e7ce13700(0000) GS:ffff8881f7300000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007fd60fbe9398 CR3: 00000001cb55c001 CR4: 00000000007606e0
  DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
  DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
  PKRU: 55555554
  Call Trace:
   erase_entry fs/proc/proc_sysctl.c:178 [inline]
   erase_header+0xe3/0x160 fs/proc/proc_sysctl.c:207
   start_unregistering fs/proc/proc_sysctl.c:331 [inline]
   drop_sysctl_table+0x558/0x880 fs/proc/proc_sysctl.c:1631
   get_subdir fs/proc/proc_sysctl.c:1022 [inline]
   __register_sysctl_table+0xd65/0x1090 fs/proc/proc_sysctl.c:1335
   br_netfilter_init+0x68/0x1000 [br_netfilter]
   do_one_initcall+0xbc/0x47d init/main.c:901
   do_init_module+0x1b5/0x547 kernel/module.c:3456
   load_module+0x6405/0x8c10 kernel/module.c:3804
   __do_sys_finit_module+0x162/0x190 kernel/module.c:3898
   do_syscall_64+0x9f/0x450 arch/x86/entry/common.c:290
   entry_SYSCALL_64_after_hwframe+0x49/0xbe
  Modules linked in: br_netfilter(+) backlight comedi(C) hid_sensor_hub max3100 ti_ads8688 udc_core fddi snd_mona leds_gpio rc_streamzap mtd pata_netcell nf_log_common rc_winfast udp_tunnel snd_usbmidi_lib snd_usb_toneport snd_usb_line6 snd_rawmidi snd_seq_device snd_hwdep videobuf2_v4l2 videobuf2_common videodev media videobuf2_vmalloc videobuf2_memops rc_gadmei_rm008z 8250_of smm665 hid_tmff hid_saitek hwmon_vid rc_ati_tv_wonder_hd_600 rc_core pata_pdc202xx_old dn_rtmsg as3722 ad714x_i2c ad714x snd_soc_cs4265 hid_kensington panel_ilitek_ili9322 drm drm_panel_orientation_quirks ipack cdc_phonet usbcore phonet hid_jabra hid extcon_arizona can_dev industrialio_triggered_buffer kfifo_buf industrialio adm1031 i2c_mux_ltc4306 i2c_mux ipmi_msghandler mlxsw_core snd_soc_cs35l34 snd_soc_core snd_pcm_dmaengine snd_pcm snd_timer ac97_bus snd_compress snd soundcore gpio_da9055 uio ecdh_generic mdio_thunder of_mdio fixed_phy libphy mdio_cavium iptable_security iptable_raw iptable_mangle
   iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_filter bpfilter ip6_vti ip_vti ip_gre ipip sit tunnel4 ip_tunnel hsr veth netdevsim vxcan batman_adv cfg80211 rfkill chnl_net caif nlmon dummy team bonding vcan bridge stp llc ip6_gre gre ip6_tunnel tunnel6 tun joydev mousedev ppdev tpm kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel ide_pci_generic piix aes_x86_64 crypto_simd cryptd ide_core glue_helper input_leds psmouse intel_agp intel_gtt serio_raw ata_generic i2c_piix4 agpgart pata_acpi parport_pc parport floppy rtc_cmos sch_fq_codel ip_tables x_tables sha1_ssse3 sha1_generic ipv6 [last unloaded: br_netfilter]
  Dumping ftrace buffer:
     (ftrace buffer empty)
  ---[ end trace 68741688d5fbfe85 ]---

commit 23da958 ("fs/proc/proc_sysctl.c: fix NULL pointer
dereference in put_links") forgot to handle start_unregistering() case,
while header->parent is NULL, it calls erase_header() and as seen in the
above syzkaller call trace, accessing &header->parent->root will trigger
a NULL pointer dereference.

As that commit explained, there is also no need to call
start_unregistering() if header->parent is NULL.

Link: http://lkml.kernel.org/r/20190409153622.28112-1-yuehaibing@huawei.com
Fixes: 23da958 ("fs/proc/proc_sysctl.c: fix NULL pointer dereference in put_links")
Fixes: 0e47c99 ("sysctl: Replace root_list with links between sysctl_table_sets")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
@heikomat
Copy link
Owner

@7twin as you know, when i tried building 5.0, i was able to build the packages, but the system wouldn't boot.
i just merged 5.1, and wasn't even able to build the packages (i got build errors). After adjusting a few lines (see here), i was not only able to build the packages, but compared to 5.0 the system boots and works as intended (or at least as good as it did with 4.20).

So i made a 5.1-cx2072x release. Could you please test your docker-arch-build with 5.1 (current master)?

@7twin
Copy link

7twin commented May 19, 2019

@heikomat sounds fantastic, well done!

Will try to test it out asap and tag you here once I do!

@roethigj
Copy link

@heikomat thanks for the kernel and script!

what is the (technical) difference to Takashi Iwai's work: (kernel/git/tiwai/sound.git)? Looks like they're working on codec and driver for current kernels. your module is cht_cx2072x, their's is byt_cht_cx2072x.

I patched a manjaro kernel some days ago using their commits and it works (https://github.com/roethigj/Linux51-manjaro-cx2072x). Just needed to adjust the UCM files.

@heikomat
Copy link
Owner

heikomat commented May 19, 2019

@roethigj as i describe here my variant of the kernel is based upon multiple patches that Takashi created for the 4.13 kernel.
Takashi didn't (to my knowledge at least) adapt the patches to work with newer kernels (up until recently, as it seems).

I'm by all means not familiar with the kernel, but i'm capable of reading build errors and find my way around source code, so with two nights of work i was able to merge and adapt his patches into the 4.16 kernel. Keeping them updated from that point on wasn't that hard.

I was not aware, that Takashi has updated his cx2072x patches for newer kernels. As you can see, his commits are only a couple of weeks old, and there are no branches for kernel versions 4.14 through 5.0:
Screenshot 2019-05-19 at 23 45 07

So... If these patches are legit (and by you're success in using them, they seem to be), then they're most likely of higher quality than my "i somehow made it work without completely breaking it"-approach. In this case, i'll probably stop using my own "based on Takeshis patches"-version, and move on to just straight up pre-building and using his patches (as the one-command-installer in this repo seems to be quite popular, especially with the linux mint folks)

@7twin
Copy link

7twin commented May 19, 2019

@heikomat just to clarify: this repo will still be updated? just not with own tinkering but merging Takashi's patches instead? (assuming these actually keep coming now, because we had nothing since 4.14 up until 5.0)

I haven't yet checked enough on what @roethigj meant with "UCM files", but possibly the docker image could do it all for us; pull latest stable kernel, check for takashi patch, apply it, fix "UCM files", then compile and output (possibly even via pipeline to auto publish it to github/gitlab releases) - though as mentioned before my approach is more in line with how the arch wiki describes compiling a kernel, rather than packaging it up as some others did (still no proper grasp on how that would work to install either, just as a regular package and then it somehow creates the necessary grub entries and all that goes with it?..), so that might need adjustments too.

@7twin
Copy link

7twin commented May 19, 2019

Also worth asking, should I hold off testing the current 5.1 or will we still keep it until #10 is ready?

@heikomat
Copy link
Owner

@7twin i just opened another issue to track the "Takashi has updated patches"-topic, see #10

This repository will definitely continue to exist, but if Takashis fixes work as intendet, i'll replace the current master-branch with Takashis cx2072x-5.1 branch (aka i'll replace my updated patches with his updated patches).

these files are meant when talking about the ucm files. They have to just exists for alsa to know what codec and driver to use and how to use them. As you can see here, my cx2072x-installer script just downloads them to the correct location.

I'd like to have the docker-builds still use this repositories master branch to build the kernel-packages, but in an ideal scenario, this repositories master branch is (nearly) identical to Takashis cx2072x branch.

This allows us to keep the ucm files and manuals with the install-command in this repo, while simultaneously making us independend, in case Takashi stops updating his patches.

@7twin
Copy link

7twin commented May 19, 2019

@heikomat

I'd like to have the docker-builds still use this repositories master branch to build the kernel-packages

This allows us to keep the ucm files and manuals with the install-command in this repo, while simultaneously making us independend, in case Takashi stops updating his patches.

Makes sense, then we'll just keep it manual and have the docker builds just continue to pull from this repo and publish pre-built packages as releases. Indeed it's a better idea to not rely on external patches exclusively.

@7twin
Copy link

7twin commented May 21, 2019

@heikomat it worked! I couldn't find any issues with it whatsoever and didn't even have to apply any renames this time 🎉 I'll need to update the instructions from 4.20 and then commit the first version of the docker setup, though I will make it into a more guided script once I have more time.

@heikomat
Copy link
Owner

Nice!

@7twin
Copy link

7twin commented May 21, 2019

Updated the instructions for now (most was still the same, just some minor changes), will then in near future make the docker setup available too: https://github.com/7twin/arch_sound_e200ha

@7twin
Copy link

7twin commented May 27, 2019

@heikomat v5.1 sound does not seem to work, did you try it out and it worked for you? I did make sure to change all occurences and add the new config lines, also downloaded the new ucm files.

@frantisheq
Copy link

#11 (comment)

@heikomat
Copy link
Owner

Sound works für me on linux mint with 5.1

@7twin
Copy link

7twin commented May 27, 2019

@frantisheq even after that and a reboot, still only a dummy output device, sadly
@heikomat guess I'll try to build again and check to make sure the options are there, if that fails, I'll try to build with the config you have in the repo.

@7twin
Copy link

7twin commented May 28, 2019

@heikomat tried to build with your config too and copied over exactly the same parameters, still no luck, in pavucontrol I can see a profile for "Atom/Celeron/.." that contains a multitude of hdmi profiles which all are marked as "(unplugged) (unavailable)" but output devices only contains the dummy.

My config is now: https://github.com/heikomat/linux_cx2072x_build/blob/master/arch_package_config/config

with that at the end:

CONFIG_SND_SOC_INTEL_BYT_CHT_CX2072X_MACH=m
CONFIG_SND_SOC_CX2072X=m
CONFIG_ACPI_ASUS=m
CONFIG_HID_ELAN=m
CONFIG_DEBUG_INFO=n

@7twin
Copy link

7twin commented May 28, 2019

I think I know my mistake, my script is pulling tag v5.1 instead of the cx2072x branch, could that be it?

@heikomat
Copy link
Owner

Yes, you definitely need to build from the cx2072x branch

@7twin
Copy link

7twin commented May 28, 2019

@heikomat pulling the "right" branch and rebuilding at first did nothing, but then creating a fresh .config without modifying it (it had all the options already seemingly, possibly because I was booted into a previous attempt kernel) and it worked! 🎉

Will try to do a full fresh install of arch and apply this kernel, just to make sure it wasn't some coincidence.

@7twin
Copy link

7twin commented May 29, 2019

@heikomat worked absolutely flawless, I updated my repo now too, to reflect the new changes as I myself forgot while testing again to switch to the new naming of ucm files and folder.

@heikomat
Copy link
Owner

heikomat commented Jul 13, 2019

@7twin good news! Starting with 5.3, the patches for the cx2072x will be in the default linux kernel! (see this commit).

We'll probably still need the alsa-ucm files, but this means that starting from 5.3, no more custom-kernels and kernel patches will be required!

@frantisheq
Copy link

nice. if someone gets camera to work on hp x2 210 finally everything will work

@7twin
Copy link

7twin commented Jul 13, 2019

@heikomat That's amazing news! wonder when 5.3 will be out for release.

@heikomat
Copy link
Owner

@7twin probably in about 5 to 7 weeks. But it will most likely take a couple more weeks or month before the different distros actually use the updated kernel

@frantisheq
Copy link

looks like ucm files are already there alsa-project/alsa-lib@108a2f4

@heikomat
Copy link
Owner

heikomat commented Jul 22, 2019

@frantisheq thanks for the link, i've been looking for this :D
This seems to not be releases though (can't see it in alsa-lib 1.1.9), so this will presumably be in alsa-lib 1.1.10 oder 1.2.0.

In that case, i'll need to do the following checks:

  • Check if lib/firmware/intel/fw_sst_22a8.bin exists, if not install firmware-intel-sound (this is already in the script, and almost all distros already have this preinstalled)
  • Check if the Kernel is at least version 5.3, if not install the latest cx2072x-custom-kernel
  • Check if alsa-lib is at least version 1.1.10, if not install the ucm-files
  • Disable realtime-scheduling in pulseaudio (would need to test is this is really still necessary)

This means i'll keep the installer script up to date up to the mentioned kernel and alsa versions, because everything newer should just work out of the box, and everything older can use the script :)

@marcin19883
Copy link

marcin19883 commented Jul 23, 2019

Im use Arch and kernel 5.3 RC1. The module cx2072x is not loaded:( but it works in ubuntu kernel mainline. Could anyone compile a kernel with the module on Arch? I do not know it, that's why I am asking you

@StefanescuCristian StefanescuCristian closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants