adjusted outdoor coverage points #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
approved these changes
Sep 10, 2025
kurotych
reviewed
Sep 10, 2025
Comment on lines
+318
to
319
| SignalLevel::Low => dec!(0), | ||
| SignalLevel::None => dec!(0), |
There was a problem hiding this comment.
These two lines could be simplified to one
_ => dec!(0),
There was a problem hiding this comment.
understood, I like it this way though, being very explicit and obvious that low signal strength is now worth 0 points
michaeldjeffrey
approved these changes
Sep 10, 2025
bbalser
force-pushed
the
bbalser/adjusted-outdoor-coverage-points
branch
from
618aa5d to
f01ff87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/helium/helium-release-proposals/blob/main/releases/20250909-core-devs.md#3-adjust-outdoor-coverage-template