Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROS Humble build #39

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Fix ROS Humble build #39

merged 3 commits into from
Jun 23, 2023

Conversation

hello-atharva
Copy link
Contributor

Summary

Bumps several ROS repos to Humble. stretch_moveit_plugins is now using the latest MoveIt API for Humble. This PR also fixes librealsense installation.

@hello-atharva hello-atharva self-assigned this May 23, 2023
@hello-atharva hello-atharva added the enhancement New feature or request label May 23, 2023
@hello-binit
Copy link
Contributor

Hi Atharva, it looks like your accounts got mixed up. The PR is opened by @hello-atharva, but the commit is authored by @atharva-18 . Can you amend the author on that commit and force push it?

@hello-binit
Copy link
Contributor

Awesome, thanks! You might add @hello-chintan as a reviewer since this merges into his branch.

@@ -6,11 +6,11 @@ repositories:
moveit_visual_tools:
type: git
url: https://github.com/ros-planning/moveit_visual_tools
version: 4.0.0
version: 4.1.0
moveit_task_constructor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hello-atharva Binaries for this package are now available. Do we need to source build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it! Should we install it here or add that package as a rosdep dependency in stretch_ros2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter sounds like a better idea. Could you add it?

@@ -6,11 +6,11 @@ repositories:
moveit_visual_tools:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hello-atharva Binaries available. Do we need to source build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hello-atharva
Copy link
Contributor Author

hello-atharva commented May 24, 2023

Looks like latest build using stretch_ros2 on rolling is failing.

Edit:
See issue source below

@hello-atharva
Copy link
Contributor Author

Are we using the latest API here?
https://github.com/hello-robot/stretch_ros2/blob/28b6a98bb718260c79cbb65fd810480f18c4865a/stretch_moveit2/stretch_moveit_config/src/moveit_draw.cpp#L143

It should be instead:

if(i <= 1){
      disp_plan.trajectory_ = my_plan.trajectory_;
}

@hello-chintan
Copy link
Contributor

@hello-atharva You're right. The MoveIt cpp code will be deprecated in Humble as we move to the Python API, so it's not necessary to update it.

@hello-binit
Copy link
Contributor

Pending Chintan's notes, I think this looks ready to merge.

@hello-chintan
Copy link
Contributor

Looks good. Merging this in.

@hello-chintan hello-chintan merged commit b1afca1 into 22.04 Jun 23, 2023
@hello-chintan hello-chintan deleted the 22.04_migration branch June 23, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants