-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ROS Humble build #39
Conversation
Hi Atharva, it looks like your accounts got mixed up. The PR is opened by @hello-atharva, but the commit is authored by @atharva-18 . Can you amend the author on that commit and force push it? |
f37125d
to
4a3da87
Compare
Awesome, thanks! You might add @hello-chintan as a reviewer since this merges into his branch. |
@@ -6,11 +6,11 @@ repositories: | |||
moveit_visual_tools: | |||
type: git | |||
url: https://github.com/ros-planning/moveit_visual_tools | |||
version: 4.0.0 | |||
version: 4.1.0 | |||
moveit_task_constructor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hello-atharva Binaries for this package are now available. Do we need to source build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it! Should we install it here or add that package as a rosdep dependency in stretch_ros2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter sounds like a better idea. Could you add it?
@@ -6,11 +6,11 @@ repositories: | |||
moveit_visual_tools: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hello-atharva Binaries available. Do we need to source build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref: #39 (comment)
Looks like latest build using Edit: |
Are we using the latest API here? It should be instead:
|
@hello-atharva You're right. The MoveIt cpp code will be deprecated in Humble as we move to the Python API, so it's not necessary to update it. |
Pending Chintan's notes, I think this looks ready to merge. |
Looks good. Merging this in. |
Summary
Bumps several ROS repos to Humble. stretch_moveit_plugins is now using the latest MoveIt API for Humble. This PR also fixes librealsense installation.