refactor(*): make "not found" error message user-friendly #5460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Eremeev <selslack@users.noreply.github.com>
helm-bot
added
the
size/M
bacongobbler
requested changes
Mar 22, 2019
pkg/kube/client.go
Outdated
| kind := info.Mapping.GroupVersionKind.Kind | ||
| return fmt.Errorf("no %s with the name %q found", kind, info.Name) | ||
| return fmt.Errorf( | ||
| "%s %q is not managed by Helm; delete the resource from the current cluster state to let Helm manage it", |
Member
There was a problem hiding this comment.
Can we please change the error message to
kind %s with the name %q already exists in the cluster and wasn't defined in the previous release. Before upgrading, please either delete the resource from the cluster or remove it from the chart.
This error can also occur if another chart is managing the resource, so "is not managed by Helm" is not always true.
pkg/kube/client.go
Outdated
|
|
||
| originalInfo := original.Get(info) | ||
|
|
||
| // Resource exists in the current cluster state, but not in the current helm configuration |
Member
There was a problem hiding this comment.
Please change this to
The resource already exists in the cluster, but it wasn't defined in the previous release. In this case, we consider it to be a resource that was previously un-managed by the release and error out, asking for the user to intervene.
Signed-off-by: Pavel Eremeev <selslack@users.noreply.github.com>
helm-bot
added
size/M
bacongobbler
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improved error message for users experiencing error described in #1193.
Special notes for your reviewer:
If applicable: