-
-
Notifications
You must be signed in to change notification settings - Fork 311
feat: add duration to affected releases on sync #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For people who uses helmfile with many and complex releases, with several helm level install/uninstall hooks and also helmfile level sync/delete hooks, it would be nice to have a summary at the end with how much time was spent in processing each individual release.
Having this information in a CI loop, for example, allows me to find out which of my releases is the actual bottleneck and deserves more optimization.
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
|
/cc @mumoshu I think this is a good idea. I saw the code. The logic is straightforward. and almost all changed files are test files. |
|
/cc @xiaomudk waiting for your review. |
|
I'll review this asap! Thanks a lot for your efforts! |
|
@AlexAxenti please fix DCO~ |
|
@felipecrs need your help. |
Yeah.. there is not much I can do now unfortunately. But thanks a lot anyway! Let's wait for @AlexAxenti. |
|
@xiaomudk @yxxhero Hey! I think @AlexAxenti has already signed-off every commit he added and it would be 8cae3e5 which made DCO check unhappy! Also, 8cae3e5 broken tests and other references to former "Duration" which is now "duration" so we'd better check this branch out locally and amend the commit to include other fixes, along with a sign-off. |
|
@AlexAxenti and I can also fix this tomorrow, if you prefer. |
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
|
Just fixed the errors caused by the incorrect Duration being referenced as well as signed-off the commits, hopefully should be good now. |
Signed-off-by: Alexandru Axenti <alex.axenti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

The purpose of this feature is to show the duration it took to update or delete each release when a sync, destroy, or apply command is called. Below are some examples:
Old display of affected releases:
New display of affected releases: