This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Improve component props #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2017 16:40
**Export propTypes**
From now on, the const `propTypes` being declared on components will be made available to be imported. This allows for easier propType re-use! All of Blue's components were updated to support this.
**Making component props more flexible**
With the rare exception of certain components (like `Portal`), most of Blue's components have been updated to accept additional props beyond the defaultPropts by using the `{...rest}` style method. The typical use-case would be to easily add custom `style` options, or perhaps `id` or `data-` properties.
**Example**
```jsx
<Avatar style={{ padding: 20 }} />
```
No changes/updates are required for the user/consumer!
These updates should work with existing integrations. 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve component props
Export propTypes
From now on, the const
propTypesbeing declared on components will be made available to be imported. This allows for easier propType re-use! All of Blue's components were updated to support this.Making component props more flexible
With the rare exception of certain components (like
Portal), most of Blue's components have been updated to accept additional props beyond the defaultPropts by using the{...rest}style method. The typical use-case would be to easily add customstyleoptions, or perhapsidordata-properties.Example
No changes/updates are required for the user/consumer!
These updates should work with existing integrations. 🚀