This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Color: Adjust values + provide ability to override #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adjusts both the `getColorShade` and `optimalTextColor` util functions to use a different RGB weight to (subjectively) better results for determining whether the text color should be black or white (given a color). The functions have also been enhanced to accept a secondary argument (object), that allows the user to override the default suggested RGB values with their own (to fine tune).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color: Adjust values + provide ability to override 🖌
This update adjusts both the
getColorShadeandoptimalTextColorutil functions to use a different RGB weight to (subjectively) better
results for determining whether the text color should be black or white
(given a color).
The functions have also been enhanced to accept a secondary argument
(object), that allows the user to override the default suggested RGB
values with their own (to fine tune).
Example: