This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Grid: Refactor + CSS-in-JS #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 18, 2018 20:50
This update refactors the various Grid components with the latest Blue conventions, such as namespacing, propConnect, and type support. It also uses CSS-in-JS for styling, powered by Fancy. Performance has also been improved as these components are now `PureComponent` classes, rather than SFC. The tests have also been adjusted to favour `mount` over `shallow` rendering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grid: Refactor + CSS-in-JS
This update refactors the various Grid components with the latest Blue
conventions, such as namespacing, propConnect, and type support.
It also uses CSS-in-JS for styling, powered by Fancy. This allow us to remove
@seedcss/seed-grid, which shaves about9kbin the compiled CSS file size (minified).For context, the Grid system is one of the larger seed packages.
Performance has also been improved as these components are now
PureComponentclasses, rather than SFC.The tests have also been adjusted to favour
mountovershallowrendering.