-
Notifications
You must be signed in to change notification settings - Fork 112
feat(uhyve): use v2 interface, MmioWrite exits on x86_64 #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
38666d5 to
eca06b1
Compare
|
Small status update: This can't work as-is yet, because we use |
eca06b1 to
8142546
Compare
| ] | ||
|
|
||
| [patch.crates-io] | ||
| uhyve-interface = { git = "https://github.com/n0toose/uhyve", branch = 'uhyve_if_v2-mmiowrite' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| uhyve-interface = { git = "https://github.com/n0toose/uhyve", branch = 'uhyve_if_v2-mmiowrite' } | |
| uhyve-interface = { git = "https://github.com/n0toose/uhyve", branch = "uhyve_if_v2-mmiowrite" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be removed, this was added to 'declare' what branch must be used and allow for easier compilation (in theory...)
465f8fc to
b4796d3
Compare
|
The issue causing the CI to fail was technically fixed in https://github.com/hermit-os/kernel/pull/2066/files, but we don't expect a new release for v1 of uhyve-interface (in which https://github.com/hermit-os/kernel/pull/2066/files would've helped.) We can work around this by using @fogti's work that effectively shifts this responsibility onto
Alternatively, we can use CC: @jounathaen, @mkroening |
This also removes the usage of ExitArgs, as it is a single integer. Co-authored-by: Ellen Εμιλία Άννα Zscheile <fogti+devel@ytrizja.de> Helped-by: Jonathan Klimt <jonathan.klimt@eonerc.rwth-aachen.de>
b4796d3 to
a5c48af
Compare
Companion PR to hermit-os/uhyve#1145