Skip to content

Conversation

@n0toose
Copy link
Member

@n0toose n0toose commented Oct 25, 2025

Companion PR to hermit-os/uhyve#1145

@n0toose n0toose marked this pull request as draft October 25, 2025 16:02
@n0toose n0toose force-pushed the uhyve-v2-mmiowrite branch from 38666d5 to eca06b1 Compare October 25, 2025 16:05
@n0toose
Copy link
Member Author

n0toose commented Nov 12, 2025

Small status update: This can't work as-is yet, because we use GuestVirtAddr for the write and read implementations inside src/fd/stdio.rs and src/fs/uhyve.rs, whereas uhyve-interface v2 should now use GuestPhysAddr instead.

]

[patch.crates-io]
uhyve-interface = { git = "https://github.com/n0toose/uhyve", branch = 'uhyve_if_v2-mmiowrite' }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uhyve-interface = { git = "https://github.com/n0toose/uhyve", branch = 'uhyve_if_v2-mmiowrite' }
uhyve-interface = { git = "https://github.com/n0toose/uhyve", branch = "uhyve_if_v2-mmiowrite" }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be removed, this was added to 'declare' what branch must be used and allow for easier compilation (in theory...)

@n0toose
Copy link
Member Author

n0toose commented Nov 14, 2025

The issue causing the CI to fail was technically fixed in https://github.com/hermit-os/kernel/pull/2066/files, but we don't expect a new release for v1 of uhyve-interface (in which https://github.com/hermit-os/kernel/pull/2066/files would've helped.)

We can work around this by using @fogti's work that effectively shifts this responsibility onto hermit-entry:

Alternatively, we can use [patch.crates-io] and force the kernel to use the latest commit for Uhyve.

CC: @jounathaen, @mkroening

This also removes the usage of ExitArgs, as it is a single integer.

Co-authored-by: Ellen Εμιλία Άννα Zscheile <fogti+devel@ytrizja.de>
Helped-by: Jonathan Klimt <jonathan.klimt@eonerc.rwth-aachen.de>
@n0toose n0toose changed the title feat(uhyve): experimental MmioWrite hypercall exiting feat(uhyve): use v2 interface, MmioWrite exits on x86_64 Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants