fix: improve basic SPDX assertion and add tests #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and improves the SPDX BOM validation logic while adding comprehensive test coverage for both CDX and SPDX BOM validation functions.
- Fixed incorrect SPDX identifier validation from "SPDXRef-Document" to "SPDXRef-DOCUMENT"
- Enhanced SPDX validation to check for required fields (spdxVersion with proper format)
- Added type safety checks for both CDX and SPDX validation functions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/bom/validation.ts | Enhanced BOM validation with stricter type checks and corrected SPDX validation logic |
| src/bom/validation.test.ts | Added comprehensive test suite covering validation functions, edge cases, and real-world examples |
sunshastry
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.