fixes handling of rejected fetches #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nfcampos
commented
Apr 12, 2016
nfcampos
commented
- fetch rejects rarely, but it does happen (eg. when the request times out), see https://fetch.spec.whatwg.org/#fetch-method for details
- fixed promise chaining in RefetchConnect#createPromise
- added tests for this behaviour
- added another branch to our testing fetch stub (which rejects the promise)
- added rejected fetch case to the 'should should props and promise state to the given component' test
- tested that catch and andCatch handlers of a rejected request are called
- fetch rejects rarely, but it does happen (eg. when the request times out), see https://fetch.spec.whatwg.org/#fetch-method for details - fixed promise chaining in RefetchConnect#createPromise - added tests for this behaviour - added another branch to our testing fetch stub - added rejected fetch case to the 'should should props and promise state to the given component' test - tested that catch and andCatch handlers of a rejected request are called
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.