Skip to content

Conversation

@nfcampos
Copy link
Contributor

@ryanbrainard any other test you can think is appropriate?
I'm testing

  • context is indeed provided as the 2nd argument
  • when context changes mapPropsToRequestsToProps is called with the new context

contextPassedIn.push(context)
return {}
})
class WithProps extends Component {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename this to InnerComponent since it actually doesn't have any props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I've renamed it.

@ryanbrainard
Copy link
Contributor

Looks good! Can you update the API doc and maybe an example in the readme?

@nfcampos
Copy link
Contributor Author

I'll update the docs.
As for the example, any example with context gets kind of verbose (defining all those contextTypes, etc.), which might be too much for the readme, no?

@ryanbrainard
Copy link
Contributor

As for the example, any example with context gets kind of verbose (defining all those contextTypes, etc.), which might be too much for the readme, no?

Yeah, perhaps. I'll merge this now and then we can add more to the readme if it adds value.

Thanks for working on this @nfcampos !

ryanbrainard added a commit that referenced this pull request Mar 16, 2016
mapPropsToRequestsToProps is called with context as 2nd argument (closes #69)
@ryanbrainard ryanbrainard merged commit 877e8d5 into heroku:master Mar 16, 2016
@nfcampos
Copy link
Contributor Author

happy to help!

@ryanbrainard
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants