Changed references to this.store in order to allow using the mixin inside components#108
Merged
hhff merged 2 commits intoadopted-ember-addons:masterfrom Dec 1, 2015
Conversation
…side components or even in simple Ember.Object.
Collaborator
|
This seems like a good change to me. |
Collaborator
|
👍 |
hhff
added a commit
that referenced
this pull request
Dec 1, 2015
Changed references to this.store in order to allow using the mixin inside components
Collaborator
|
Thanks @mariuszzak ! |
Collaborator
|
@richardvenneman First thing I notice is the model hook you are using is only called in routes, not components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the same problem mentioned in #93 issue. I'd like to use the mixin inside components, not in routes. Actually it would be nice to have reference to
this.get('store')insteadthis.store. I don't have injectedstoreto each component, so it's not possible to usethis.storestatement even I explicitly inject bystore: Ember.inject.service(). Furthermore this change doesn't affect nothing more, so it only extend the configurability.