"Rebrand" the extension to work with the Validator as well

[marko-bekhta]

I had a quick check on integrating Develocity with Validator. From what it seems, most of the things would work as is from the extension perspective, except maybe adjusting the tag here:

https://github.com/hibernate/hibernate-search-develocity-extension/blob/6c369171caecdcd7a3539d1edc92df10d3234299/src/main/java/org/hibernate/search/develocity/scan/BuildScanMetadata.java#L38

maybe to something like

// e.g. "org.hibernate.search" or "org.hibernate.validator"
buildScanApi.tag( currentProject.getModel().getGroupId() );

and then doing some renaming... maybe:

    <groupId>org.hibernate.infra.develocity</groupId>
    <artifactId>hibernate-develocity-maven-extension</artifactId>

and here's a link to one of the local builds https://ge.hibernate.org/s/n7r6spbey4wrc (when most of the stuff got cached)

[marko-bekhta]

@yrodiere let me know if this makes sense to you 🙈

[yrodiere]

I missed this notification, sorry... everything you said LGTM, please go ahead 👍

[yrodiere]

@marko-bekhta did you look through the code though? I see a few things that look very specific to Search, e.g. this:

https://github.com/hibernate/hibernate-search-develocity-extension/blob/6c369171caecdcd7a3539d1edc92df10d3234299/src/main/java/org/hibernate/search/develocity/plugins/ForbiddenApisConfiguredPlugin.java#L42-L46

[marko-bekhta]

yeah ... I looked at the other plugins and was thinking: ooook validator does not use these properties so it won't get into these conditions when running there ... but I missed this one 🙈 😕 thanks for pointing to it. Coincidentally (or is it 😏), Validator also uses the build config artefact to share additional forbiddenapis files, so it turned out to be a matter of pointing to the correct artifact depending on what we are building.
So I went with checking the group ids and then doing the additional checks per "project": #29

[yrodiere]

Fixed by #29

Follow-up work:

• do a 3.0.0 release.
• update Search/Validator to use the new extension version